vinz/pixelfed-scatto
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Announce a remote DM as a message too, not a mention #2

Manually merged
vinz merged 0 commits from feature/dm-web-push into hever-next 2026-09-02 15:50:36 +02:00
Conversation 0 Commits - Files changed -
vinz commented 2026-09-02 14:12:08 +02:00
Owner
Copy link

Follow-up to #1, which is already merged and deployed.

A remote DM (arriving through Inbox) already had a Web Push dispatch, sending mention. #1 added the local path as dm, so the same event announced itself two different ways depending on which instance the sender is on — "New Message" from someone local, "New Mention" from someone remote. That is what Vinz observed on the device.

Both now say dm.

The Expo block directly above still says mention deliberately: it is upstream's code, and the official app renders mention but has no case for dm.

Follow-up to #1, which is already merged and deployed. A remote DM (arriving through `Inbox`) already had a Web Push dispatch, sending `mention`. #1 added the local path as `dm`, so the same event announced itself two different ways depending on which instance the sender is on — "New Message" from someone local, "New Mention" from someone remote. That is what Vinz observed on the device. Both now say `dm`. The Expo block directly above still says `mention` deliberately: it is upstream's code, and the official app renders `mention` but has no case for `dm`.
A direct message from another instance arrives through Inbox and already
had a Web Push dispatch — sending 'mention'. It was written when that was
the only DM push there was, and before Scatto had a conversation view to
send anyone to. With DirectMessageController now sending 'dm' for a local
sender, the same event announced itself two different ways depending on
which instance the other person is on: "New Message" from someone here,
"New Mention" from someone elsewhere.

Both now say 'dm'.

The Expo block directly above still says 'mention'. That is upstream's
code and upstream's decision: the official app renders 'mention' and has
no case for 'dm', so changing it would break their client to tidy ours.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ESWRjpNGAwyaKGGPc5n39X
vinz manually merged commit 5bac120488 into hever-next 2026-09-02 15:50:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
vinz/pixelfed-scatto!2
No description provided.